fix(ring): duplicate should clear original block#2916
Merged
icecrasher321 merged 2 commits intostagingfrom Jan 21, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryFixed bug where the editor panel's ring selection ( Changes
ImpactThis fix ensures consistent behavior across all selection scenarios - the ring selection now properly clears when multiple blocks are selected, regardless of whether the selection came from a duplicate/paste operation or direct user interaction. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant ContextMenu
participant WorkflowContent
participant ExecutePaste
participant Effect
participant PanelEditor as usePanelEditorStore
participant Canvas
User->>ContextMenu: Click Duplicate
ContextMenu->>WorkflowContent: handleContextDuplicate()
WorkflowContent->>WorkflowContent: copyBlocks()
WorkflowContent->>ExecutePaste: executePasteOperation('duplicate')
ExecutePaste->>WorkflowContent: setPendingSelection(pastedBlockIds)
ExecutePaste->>WorkflowContent: collaborativeBatchAddBlocks()
Note over Effect: Effect detects pendingSelection
Effect->>Effect: Apply selection to nodes
Effect->>Effect: resolveParentChildSelectionConflicts()
Effect->>Effect: Calculate selectedIds
alt Single block selected
Effect->>PanelEditor: setCurrentBlockId(selectedIds[0])
PanelEditor->>Canvas: Show ring around selected block
else Multiple blocks selected (NEW FIX)
Effect->>PanelEditor: clearCurrentBlock()
PanelEditor->>Canvas: Clear ring selection
else No blocks selected
Effect->>PanelEditor: clearCurrentBlock()
PanelEditor->>Canvas: Clear ring selection
end
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist